Great Pull Requests

This one is about tactics.

A great pull request saves time—time you'd otherwise spend in meetings, fixing incidents, or stuck in endless revisions.

  1. Be your first reviewer.
    Scrub away the rough edges before you ask others to dive in. Thoughtful, high-quality changes inspire everyone to follow suit and become an educational goldmine for newcomers.

  2. Set the Context.
    What?, Why?, and How? Your pull request should be self-contained. Reviewers should not have to spend time deciphering its background or implications.

  3. Keep it clean, keep it short.
    Stick to one concern per pull request. The change may be complex, yet it should be simple to review. When things go sideways, atomic changes expedite the assessment of root causes, side effects, and stabilization strategies, thus saving precious time.

— fabián